Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize references to application.yaml files in reference docs #34628

Closed
wants to merge 2 commits into from
Closed

Harmonize references to application.yaml files in reference docs #34628

wants to merge 2 commits into from

Conversation

ivandimitrov8080
Copy link
Contributor

#34624

Changed most yml to yaml, except for this one:

`The following example `scrape_config` adds to `prometheus.yml`:

And this one:

|YAML
| `com.fasterxml.jackson.core:jackson-databind` + `com.fasterxml.jackson.dataformat:jackson-dataformat-yaml`
| `log4j2.yaml` + `log4j2.yml`

|JSON
| `com.fasterxml.jackson.core:jackson-databind`
| `log4j2.json` + `log4j2.jsn`
|===

The prometheus docs refer to their config file as prometheus.yml.

The log4j example looks consistent enough with what is below it.

@pivotal-cla
Copy link

@ivandimitrov8080 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@ivandimitrov8080 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 17, 2023
wilkinsona
wilkinsona requested changes Mar 17, 2023
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @ivandimitrov8080. I've left a few comments for your consideration.

spring-boot-project/spring-boot-docs/src/docs/asciidoc/deployment/cloud.adoc Outdated Show resolved Hide resolved
spring-boot-project/spring-boot-docs/src/docs/asciidoc/deployment/cloud.adoc Outdated Show resolved Hide resolved
spring-boot-project/spring-boot-docs/src/docs/asciidoc/io/hazelcast.adoc Outdated Show resolved Hide resolved
spring-boot-project/spring-boot-docs/src/docs/asciidoc/io/hazelcast.adoc Outdated Show resolved Hide resolved
spring-boot-project/spring-boot-docs/src/docs/asciidoc/using/devtools.adoc Outdated Show resolved Hide resolved
spring-boot-project/spring-boot-docs/src/docs/asciidoc/features/external-config.adoc Outdated Show resolved Hide resolved
spring-boot-project/spring-boot-docs/src/docs/asciidoc/features/external-config.adoc Outdated Show resolved Hide resolved
spring-boot-project/spring-boot-docs/src/docs/asciidoc/features/external-config.adoc Outdated Show resolved Hide resolved
spring-boot-project/spring-boot-docs/src/docs/asciidoc/howto/properties-and-configuration.adoc Outdated Show resolved Hide resolved
spring-boot-project/spring-boot-docs/src/docs/asciidoc/howto/properties-and-configuration.adoc Outdated Show resolved Hide resolved
@scottfrederick scottfrederick added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 20, 2023
@scottfrederick scottfrederick added this to the 2.7.x milestone Mar 20, 2023
@scottfrederick scottfrederick mentioned this pull request Mar 20, 2023
Closed
@wilkinsona wilkinsona changed the title changing yml to yaml for consistency Use a consistent file extension when referring to application.yaml files Mar 24, 2023
@snicoll snicoll changed the title Use a consistent file extension when referring to application.yaml files Harmonize reference to YAML files in reference docs Apr 24, 2023
@snicoll snicoll changed the title Harmonize reference to YAML files in reference docs Harmonize references to YAML files in reference docs Apr 24, 2023
@snicoll snicoll self-assigned this Apr 24, 2023
@snicoll snicoll changed the title Harmonize references to YAML files in reference docs Harmonize references to application.yaml files in reference docs Apr 24, 2023
@snicoll snicoll modified the milestones: 2.7.x, 2.7.12 Apr 24, 2023
@snicoll snicoll mentioned this pull request Apr 24, 2023
Closed
snicoll pushed a commit that referenced this pull request Apr 24, 2023
@ivandimitrov8080 @snicoll
Harmonize references to application.yaml files in reference docs
f4db73e 
See gh-34628
@snicoll snicoll closed this in be698cf Apr 24, 2023
@snicoll
Copy link
Member

snicoll commented Apr 24, 2023

@ivandimitrov8080 thank you for making your first contribution to Spring Boot.

@Netyyyy Netyyyy mentioned this pull request May 25, 2023
Closed
@Netyyyy Netyyyy mentioned this pull request Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona wilkinsona requested changes

Assignees

@snicoll snicoll

Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.7.12
Development

Successfully merging this pull request may close these issues.
6 participants
@ivandimitrov8080 @pivotal-cla @snicoll @wilkinsona @scottfrederick @spring-projects-issues